Upgrade ant icons to 5.4 #8007
Merged
Upgrade ant icons to 5.4 #8007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
reviewed
Aug 19, 2024
package.json
Outdated
| @@ -1,17 +1,14 @@ | |||
| { | |||
| "name": "webknossos", | |||
| "license": "AGPL-3.0", | |||
| "engines": | |||
There was a problem hiding this comment.
in another pr, I also had the problem that the package.json was entirely reformatted. later I had annoying merge conflicts in other prs. could you try to undo these changes?
the proper solution will be to update biome and then let it run on package.json, too. the current version will always skip package.json (see biomejs/biome#1668).
updating requires lots of small fixes, though, as biome got smarter. so, this should be a different pr.
hotzenklotz
approved these changes
Aug 19, 2024
dieknolle3333
pushed a commit
that referenced
this pull request
Sep 2, 2024
* upgrade ant icons to 5.4 * remove iconfont * changelog * reformat package.json --------- Co-authored-by: Philipp Otto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades ant icons to 5.4 matching the version of the main antd package.
Also, ant-icons now use inline svg instead of iconfonts, so we can remove our custom handling of the iconfont.